Adding needed functionality to nonhom_grip.py #2035
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2035 +/- ##
==========================================
- Coverage 61.33% 57.59% -3.75%
==========================================
Files 75 77 +2
Lines 8602 8737 +135
==========================================
- Hits 5276 5032 -244
- Misses 3326 3705 +379
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
wkerzendorf
reviewed
May 31, 2022
| from tardis.montecarlo.montecarlo_numba.numba_config import ENABLE_NONHOMOLOGOUS_EXPANSION | ||
|
|
||
| @njit(**njit_dict_no_parallel) | ||
| def velocity(r_packet, shell_id, numba_model): |
wkerzendorf
reviewed
May 31, 2022
| v = velocity(r_packet, shell_id, numba_model) | ||
| r = r_packet.r | ||
| dvdr = dvdr(shell_id, numba_model) | ||
| mu = r_packet.mu |
There was a problem hiding this comment.
write where the formula is from
There was a problem hiding this comment.
should I add that to the individual functions?
6 tasks
sonachitchyan
force-pushed
the
nonhom_grid
branch
from
4869133
to
79b012d
Compare
|
This has been done now right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Adding nonhom_grid.py that includes velocity and $ \frac{dv}{dr}$ functions for shells and finding tau_sobolev_factor
Some of the changes shown here are part of #2024
Also, link issues affected by this pull request by using the keywords:
close,closes,closed,fix,fixes,fixed,resolve,resolvesorresolved.📌 Resources
Examples, notebooks, and links to useful references.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docslabel