Fix spatial queries by explicitly referencing table names #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, queries using `select *` could lead to ambiguous column issues
in complex queries. This update ensures that all queries explicitly reference
the table name (`{table}.*`) to prevent conflicts and improve SQL clarity.
Additionally, test assertions have been updated to reflect this change.
frkcn
approved these changes
Feb 20, 2025
Closed
tkaratug
added a commit
that referenced
this pull request
Feb 20, 2025
Fix spatial queries by explicitly referencing table names
tkaratug
added a commit
that referenced
this pull request
Feb 24, 2025
Merge pull request #37 from tarfin-labs/specifying-table-name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR builds upon and expands the changes introduced in #33. While the original PR addressed an issue with spatial queries, this PR refines the implementation further to ensure explicit table references in SELECT queries, reducing ambiguity and improving query reliability. As a result, PR #33 will be closed in favor of this one.
Changes
scopeSelectDistanceToandnewQuerymethods inHasSpatialto use{$this->getTable()}.*instead of*.HasSpatialTestto reflect these changes.Why?
Testing
Notes
This change is fully backward-compatible and does not alter existing behavior beyond ensuring explicit table references.
Checklist