New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integrationkey/uik: refactor eval logic #4142

Open

mastercactapus wants to merge 3 commits into master from uik-eval-cleanup

+424 −148

Member

mastercactapus commented Nov 14, 2024 •

edited

Loading

Description:
Refactors the evaluation code to make it easier to read, maintain, and test.

Also:

Fixed an issue where TriggerService was being called multiple times per request
Added user agent, IP, and query parameter support to the environment context

Breaking up compile and run steps is necessary for planned future changes:

adding compile cache
tracking success/failure of eval (for sampling)
adding dry-run functionality

mastercactapus added 3 commits

November 14, 2024 16:37


          refactor: replace compilerule with compiledrule and related structures

374a844


          test: add unit tests for CompiledRule functionality

81772ea


          test: add unit tests for CompiledConfig functionality

48f4be8

github-actions bot added the size/l label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels