Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing todos title to its page title in React Js Example #2089

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Changing todos title to its page title in React Js Example #2089

wants to merge 2 commits into from

Conversation

andrehgdias
Copy link

@andrehgdias andrehgdias commented Oct 23, 2019

Partial solution/adition to #1977 with pretty simple changes:

  • The h1 title element sets its inner HTML with page title (in examples/react/js/app.jsx)
  • Css property font-size and top, from .todoapp h1, altered to fit its page title text ( examples/react/node_modules/todomvc-app-css/index.css).

Just need to know if it's okay to do these alterations.

@andrehgdias andrehgdias changed the title Feature/descriptive titles Changing Todos Title to its Page Title Oct 23, 2019
@andrehgdias andrehgdias changed the title Changing Todos Title to its Page Title Changing todos title to its page title in React Js Example Oct 23, 2019
@lyndseypadget
Copy link

This looks fine to me, despite the failing build (@FadySamirSadek, can you advise on missing env variables?)

If a core team member agrees, I would prefer updating all example apps in this way in one PR as opposed to a separate PR for each. You could continue updating this branch until they are all done AFAIC.

@andrehgdias
Copy link
Author

That's ok to me, but I can work only on a few of the examples since I'm still studying JavaScript programming and its huge ecosystem.

@FadySamirSadek
Copy link
Collaborator

This looks fine to me, despite the failing build (@FadySamirSadek, can you advise on missing env variables?

The test suite is currently broken but I'm working to fix that.

If a core team member agrees, I would prefer updating all example apps in this way in one PR as opposed to a separate PR for each. You could continue updating this branch until they are all done AFAIC.

I agree this should be done in a single PR. If you can work with @andrehgdias on that, it would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants