Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JavaScript ES5 to update folder #2206

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

flashdesignory
Copy link
Collaborator

@flashdesignory flashdesignory commented Sep 22, 2023

This is a maintenance update to the existing vanilla js implementation.

changes:

  • added proper package.json
  • updated readme file
  • renamed "js" to "src"
  • add build script (this moves all necessary files to a dist folder for the tests)
  • add dev server (for local preview)
  • pin node version (18.13.0)
  • fixed toggle all
  • removed node_modules folder from github (since we have a package-lock files)

No refactoring of logic or styling updates have been implemented.

This version has been lifted from Speedometer and follows the WebKit styles guide.
For more context regarding this update, please view #2199.

@kara

@FadySamirSadek
Copy link
Collaborator

What updates does this implementation bring to the already existing Vanilla JS TodoMVC app

@flashdesignory
Copy link
Collaborator Author

What updates does this implementation bring to the already existing Vanilla JS TodoMVC app

Updated the pr description and adjusted the index.html file to ensure proper credit is given.

@flashdesignory flashdesignory merged commit 7f34e56 into tastejs:master Oct 30, 2023
@flashdesignory flashdesignory deleted the examples-es5 branch October 30, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants