Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve gradle build cache stability #102

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: improve gradle build cache stability #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/kotlin/net/ltgt/gradle/errorprone/ErrorProneOptions.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,11 @@ import org.gradle.api.tasks.Optional
import org.gradle.api.tasks.compile.CompileOptions
import org.gradle.kotlin.dsl.* // ktlint-disable no-wildcard-imports
import org.gradle.process.CommandLineArgumentProvider
import java.io.Serializable

open class ErrorProneOptions constructor(
objectFactory: ObjectFactory,
) {
) : Serializable {
/**
* Allows disabling Error Prone altogether for the task.
*
Expand Down Expand Up @@ -109,6 +110,7 @@ open class ErrorProneOptions constructor(
@get:Nested val errorproneArgumentProviders: MutableList<CommandLineArgumentProvider> = arrayListOf()

companion object {
private const val serialVersionUID: Long = 123
const val NAME = "errorprone"
}

Expand Down
12 changes: 10 additions & 2 deletions src/main/kotlin/net/ltgt/gradle/errorprone/ErrorPronePlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import org.gradle.api.tasks.compile.JavaCompile
import org.gradle.kotlin.dsl.* // ktlint-disable no-wildcard-imports
import org.gradle.process.CommandLineArgumentProvider
import org.gradle.util.GradleVersion
import java.io.Serializable
import javax.inject.Inject

/**
Expand Down Expand Up @@ -158,7 +159,10 @@ internal class ErrorProneJvmArgumentProvider(
private val task: JavaCompile,
private val errorproneOptions: ErrorProneOptions,
private val javacConfiguration: FileCollection,
) : CommandLineArgumentProvider, Named {
) : CommandLineArgumentProvider, Named, Serializable {
companion object {
private const val serialVersionUID: Long = 1
}

@Internal override fun getName(): String = "errorprone"

Expand Down Expand Up @@ -188,7 +192,11 @@ internal class ErrorProneJvmArgumentProvider(

internal class ErrorProneCompilerArgumentProvider(
private val errorproneOptions: ErrorProneOptions,
) : CommandLineArgumentProvider, Named {
) : CommandLineArgumentProvider, Named, Serializable {

companion object {
private const val serialVersionUID: Long = 1
}

@Internal override fun getName(): String = "errorprone"

Expand Down