Normative: add Intl.DurationFormat #943
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry. click accidentially. reopen. TC39 reach Stage 4 concensus on 2024-12-02 . We should merge this |
ptomato
reviewed
Feb 13, 2025
| 1. If abs(_normalizedSeconds_) ≥ 2<sup>53</sup>, return *false*. | ||
| 1. Return *true*. | ||
| </emu-alg> | ||
| <emu-note>The abstract operations ToIntegerIfIntegral, DurationSign, and IsValidDuration take the same parameters as the abstract operations of the same name in the Temporal proposal's specification, aside from the use of a Duration Record instead of a Temporal.Duration instance. They will be removed in favor of the equivalent Temporal abstract operations if the Temporal proposal becomes part of ECMAScript before this proposal does.</emu-note> |
There was a problem hiding this comment.
I'd delete this note, it's irrelevant once this PR is merged.
There was a problem hiding this comment.
hmm, I was under the impression that this note would need to be changed and that the idea would be that once Temporal lands the AOs would be removed from 402 and we'd use AOs from 262 instead.
There was a problem hiding this comment.
Yes, that's still the idea, but I don't think the note is relevant. Temporal moves several more AOs from 402 into 262, not just these.
ptomato
added a commit
to tc39/proposal-temporal
that referenced
this pull request
Feb 13, 2025
DurationSign no longer needs to be defined by Temporal, as it's now part of ECMA-402. However, when Temporal becomes part of ECMA-262, we do need to move DurationSign into ECMA-262. Put it in a <del> block in intl.html. We can keep the new definition in its current place in the spec while adjusting its ID. Once Temporal.Duration objects are introduced, there is no longer any need for Duration Records. So, make the ECMA-402 DurationSign accept a Temporal.Duration object (as it already did in Temporal), delete the ToDurationRecord operation and the Duration Record definition, and change several other operations from ECMA-402 to use Temporal.Duration objects instead of Duration Records. Temporarily, since these operations aren't yet in ecma402-biblio pending tc39/ecma402#943, add a JSON bibliography file so the references aren't dangling.
ptomato
added a commit
to tc39/proposal-temporal
that referenced
this pull request
Feb 13, 2025
DurationSign no longer needs to be defined by Temporal, as it's now part of ECMA-402. However, when Temporal becomes part of ECMA-262, we do need to move DurationSign into ECMA-262. Put it in a <del> block in intl.html. We can keep the new definition in its current place in the spec while adjusting its ID. Once Temporal.Duration objects are introduced, there is no longer any need for Duration Records. So, make the ECMA-402 DurationSign accept a Temporal.Duration object (as it already did in Temporal), delete the ToDurationRecord operation and the Duration Record definition, and change several other operations from ECMA-402 to use Temporal.Duration objects instead of Duration Records. Temporarily, since these operations aren't yet in ecma402-biblio pending tc39/ecma402#943, add a JSON bibliography file so the references aren't dangling.
ptomato
added a commit
to tc39/proposal-temporal
that referenced
this pull request
Feb 14, 2025
DurationSign no longer needs to be defined by Temporal, as it's now part of ECMA-402. However, when Temporal becomes part of ECMA-262, we do need to move DurationSign into ECMA-262. Put it in a <del> block in intl.html. We can keep the new definition in its current place in the spec while adjusting its ID. Once Temporal.Duration objects are introduced, there is no longer any need for Duration Records. So, make the ECMA-402 DurationSign accept a Temporal.Duration object (as it already did in Temporal), delete the ToDurationRecord operation and the Duration Record definition, and change several other operations from ECMA-402 to use Temporal.Duration objects instead of Duration Records. Temporarily, since these operations aren't yet in ecma402-biblio pending tc39/ecma402#943, add a JSON bibliography file so the references aren't dangling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/tc39/proposal-intl-duration-format