Polyfill: Call DifferenceInstant() correctly from DifferenceZonedDateTimeWithRounding() (#3035)

[catamorphism]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.70%. Comparing base (4040485) to head (5c78fba).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3036   +/-   ##
=======================================
  Coverage   95.70%   95.70%           
=======================================
  Files          21       21           
  Lines        9695     9695           
  Branches     1741     1742    +1     
=======================================
  Hits         9279     9279           
  Misses        364      364           
  Partials       52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ptomato]

Thanks!
(And I'm glad this wasn't a problem in the spec text)

It would be nice to land this together with the increased test262 coverage that led you to find this bug. So I won't merge it straightaway.

The way to do it would be to get the test262 PR reviewed and merged first, then push another commit to this PR updating the test262 submodule to the latest state of main, then merge this PR.

[catamorphism]

The way to do it would be to get the test262 PR reviewed and merged first, then push another commit to this PR updating the test262 submodule to the latest state of main, then merge this PR.

Submitted the test262 PR: tc39/test262#4306

[ptomato]

Sorry, I messed up my code review suggestion in the test262 PR. I've corrected it in tc39/test262#4320, and I'll push another update commit once that's merged.

[ptomato]

Looks like the polyfill fails one of the new Date.prototype.toTemporalInstant tests that were merged into test262 in the intervening time. I'll open another PR to fix that so we can update test262 past that commit.

@catamorphism Truly sorry that this quick bugfix is turning out to be so complicated to get merged!