Add language clarifying the 32-bit limit for VLQs #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses issue tc39#80
jkup
approved these changes
Jun 25, 2024
jridgewell
approved these changes
Jun 25, 2024
github-actions bot
added a commit
that referenced
this pull request
Jun 26, 2024
SHA: 66bdf0d Reason: push, by jkup Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
I was wondering, what should tools do in case the limit is exceeded? Should we define a behavior or is that up to the implementers? I guess it is different for generators than debuggers. Generators could crash or noop while debuggers could simply reject the sourcemap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #80. I'm adding it here to have for discussion when we go through all the spec issues in the hackfest.