Add syntax tests for import.defer
#4374
Conversation
nicolo-ribaudo
force-pushed
the
import-defer-syntax-tests
branch
from
919e9f8 to
a9a33ed
Compare
| template: syntax/invalid | ||
| info: | | ||
| ImportCall : | ||
| import . source ( AssignmentExpression[+In, ?Yield] ) |
There was a problem hiding this comment.
| import . source ( AssignmentExpression[+In, ?Yield] ) | |
| import . defer ( AssignmentExpression[+In, ?Yield, ?Await] ) |
| //- setup | ||
| // This is still valid in script code, and should not be valid for module code | ||
| // https://tc39.github.io/ecma262/#sec-scripts-static-semantics-lexicallydeclarednames | ||
| var smoosh; function smoosh() {} | ||
|
|
There was a problem hiding this comment.
I did not realize that we had automatic setup and teardown substitution variables in the test generator! (They are documented; I just never noticed.)
Anyway, not having flags: [module] in the test seems like it's sufficient for ensuring it's executed as script code, so is this really needed?
There was a problem hiding this comment.
I copied this from the import.source tests (these .case files are basically a copy-paste of those). It is also use in the import tests. I'm going to remove it from the import.defer tests, but probably it should then also be removed from those, since it's indeed useless (unless we want to catch broken test262 runners).
There was a problem hiding this comment.
Sure, would you like to make a follow-up PR for that?
There was a problem hiding this comment.
I'll open an issue assigned to myself for now :P
|
I tried running this on the WebKit prototype implementation and the implementation and tests agreed, so looks good from that perspective. |
These tests are all based on the existing dynamic import syntax tests, just updated to use the new syntax. This PR does not contain any manually written tests -- they are all generated.
ptomato
force-pushed
the
import-defer-syntax-tests
branch
from
5b558ea to
a9d3eb6
Compare
These tests are all based on the existing dynamic import syntax tests, just updated to use the new syntax.
This PR does not contain any manually written tests -- they are all generated.
Ref #4215