v2: Implement Extractor and Finalizer roles #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current v0 extractor code only works for the happy path, it does not do checks on the input PSBT as specified by the bip. Add a TODO and also copy the relevant text from bip-174.
This code was just cut'n'paste and isn't currently being built. Just delete it and we will start from scratch.
Add two methods to the `InputBuilder` to add funding utxos. Note that it would really be better to use the type system to enforce existence of the funding utxo but doing so would take us away from `Input` being a 1-1 representation of the bip.
tcharding
force-pushed
the
01-13-extract
branch
from
0aa5252
to
562fb18
Compare
Add types for the two new roles. Feature gate the `Finalizer` on "miniscript". Because another entity may be the Finalizer do not feature gate the `Extractor` oven thought transaction extraction is only possible for a finalized PSBT.
tcharding
force-pushed
the
01-13-extract
branch
from
562fb18
to
54fa5da
Compare
|
Extractor should be prioritized and finalizer deprioritized. rust-bitcoin got away without a finalizer for life so far, so this could start by continuing to ignore it to get a workable v2, if it introduces too many TODOs. In payjoin-cli PSBTs get sent to bitcoind to be finalized. It just extracts a tx to broadcast from that external finalizer. A missing finalizer still makes for a useful library. |
|
Oh sweet! Extractor role is simple and it is done by this PR, with one caveat: // TODO: Check this MAX is correct.
sequence: self.sequence.unwrap_or(Sequence::MAX), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 preparator patches then a big one adding
ExtratorandFinalizertypes that wrapPsbt. There are a ton of TODOs introduced with this PR.The errors probably need some polishing, I'm particularly unimpressed with only being able to derive
Debugon loads of them.