I might just have this screwed up, but, #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you, your repo is super helpful to me. I can't get v0.rs to sign the psbt as is. If psbt.bip32_derivation does not have public key : KeySource, the keypair never signs the transaction because psbt.sign calls bip32_sign_ecdsa() for ecdsa signatures, and bip32_sign_ecdsa() iterates over psbt.bip32_derivation, so I faked the BTreeMap<PublicKey, KeySource> entries for each pk. Thanks again! BE
Update v0.rs
|
Nice! I'm glad you find the crate useful. I'll merge this when CI is green, you have some import statements to add. Thanks! |
|
I told you I must have screwed it up! Thanks for all your work.
BE
Get your free encrypted mail account at protonmail.com and your communications with Motia will be encrypted end to end.
Sent with [Proton Mail](https://proton.me/mail/home) secure email.
…On Tuesday, October 15th, 2024 at 17:32, Tobin C. Harding ***@***.***> wrote:
Nice! I'm glad you find the crate useful. I'll merge this when CI is green, you have some import statements to add.
Thanks!
—
Reply to this email directly, [view it on GitHub](#34 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AC3JL3FW2XHNF7IXYADUNVLZ3WQY7AVCNFSM6AAAAABP775J2KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJVGM2DANZUHE).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Why are you spamming we with advertising about protonmail? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you, your repo is super helpful to me. I can't get v0.rs to sign the psbt as is. If psbt.bip32_derivation does not have public key : KeySource, the keypair never signs the transaction because psbt.sign calls bip32_sign_ecdsa() for ecdsa signatures, and bip32_sign_ecdsa() iterates over psbt.bip32_derivation, so I faked the BTreeMap<PublicKey, KeySource> entries for each pk. Thanks again! BE