Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clip for graph #11

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Fix clip for graph #11

merged 2 commits into from
Aug 29, 2024

Conversation

RockyZeroFour
Copy link
Contributor

@RockyZeroFour RockyZeroFour commented Jun 11, 2024 •
edited
Loading

  • Prevent potential overflow of the graph Y value
  • Also considers large coordinates now for the clip handling
  • Removes obsolete graph settings (X coordinate settings because these are limited to a scattered graph)
  • Maps data point count to ticks on the X axis (so the data points actually match up the ticks on the X-axis)

@RockyZeroFour
Fix clip for graph
d1795e5 
- Prevent overflow of the next graph value
- Also considers large coordinates now
@RockyZeroFour
Improved graph handling
21e255e 
- Show the same amount of data points as total ticks
- This fixes the problem that only 10 data points are mapped to 11 points of the X axis
- Removed the chart range for the X axis because that only apply for the scatter graph type while the bar type is used instead
@maximevince
Copy link
Contributor

Thanks for your PR! I'll review it and keep you posted. Sorry for the delay, I've somehow missed the PR earlier.

@maximevince maximevince merged commit affb05e into teamfinalmouse:main Aug 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RockyZeroFour @maximevince