Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove create clusterrole in triggers test #2471

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

piyush-garg
Copy link
Contributor

This will remove creating clusterrole in triggers test as it is shipped by triggers now and an be used in clusterolebinding

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

Remove create clusterrole in triggers test

This will remove creating clusterrole in triggers test
as it is shipped by triggers now and an be used in clusterolebinding
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 15, 2025
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 15, 2025
@chmouel
Copy link
Member

chmouel commented Jan 15, 2025

thanks 🙏🏻

i think we can force approve to unlock ci

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2025
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2025
@tekton-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from chmouel after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@piyush-garg piyush-garg force-pushed the fix_e2e branch 15 times, most recently from 15f7a0c to 3a1cf01 Compare January 16, 2025 04:51
@piyush-garg piyush-garg force-pushed the fix_e2e branch 8 times, most recently from 2b4bf3d to 149f7c3 Compare January 16, 2025 18:44
@tekton-robot
Copy link
Contributor

@piyush-garg: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-cli-integration-tests 91268d3 link true /test pull-tekton-cli-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants