-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove create clusterrole in triggers test #2471
base: main
Are you sure you want to change the base?
Conversation
This will remove creating clusterrole in triggers test as it is shipped by triggers now and an be used in clusterolebinding
thanks 🙏🏻 i think we can force approve to unlock ci /lgtm |
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
15f7a0c
to
3a1cf01
Compare
2b4bf3d
to
149f7c3
Compare
@piyush-garg: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This will remove creating clusterrole in triggers test as it is shipped by triggers now and an be used in clusterolebinding
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make check
make generated
See the contribution guide
for more details.
Release Notes