Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: PhoneNumberValidator #62

Closed
wants to merge 87 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
87 commits
Select commit Hold shift + click to select a range
bea290e
Prepare new class PhoneNumberValidator - currently just reusing Phone…
Anrufliste May 1, 2024
b61cf95
Providing Ludwigshafen besides Mannheim for NDC 621 based on the star…
Anrufliste May 4, 2024
3f8031b
Use PhoneLib 8.13.36 and prepare release (#64)
Anrufliste May 4, 2024
bfc5f2b
Update copyright year of initial setting
Anrufliste May 1, 2024
82ba37c
Initial testing 5 separated cases
Anrufliste May 4, 2024
caf0d11
Prepare new class PhoneNumberValidator - currently just reusing Phone…
Anrufliste May 1, 2024
4354081
Update copyright year of initial setting
Anrufliste May 1, 2024
35936ba
Initial testing 5 separated cases
Anrufliste May 4, 2024
389e372
Merge branch 'Validator' of https://github.com/telekom/phonenumber-no…
Anrufliste May 5, 2024
2ba7425
Create Area Code Extractor (NDC) for Germany.
Anrufliste May 20, 2024
4c82ff0
Extend Number Plan to provide multi dimensional short code information.
Anrufliste May 20, 2024
de892a4
Starting Validator.
Anrufliste May 20, 2024
0bc33c5
Include Mobile NDCs into generator script for GermanAreaCodeExtractor…
Anrufliste May 21, 2024
f2119be
Short Code 110 and 112 are not valid start for fixed line numbers (ND…
Anrufliste May 22, 2024
c0536dc
Short Code 110 and 112 are not valid start for fixed line numbers (ND…
Anrufliste May 30, 2024
a8a82d9
Merge branch 'main' into Validator
Anrufliste May 30, 2024
84c7974
Use PhoneLib 8.13.38 and prepare release (removed NAC from MX numberp…
Anrufliste May 30, 2024
af0b626
Starting Snapshot 1.2.4 (#69)
Anrufliste May 30, 2024
6e0694d
Introducing INVALID_PREFIX_OF_SUBSCRIBER_NUMBER and reorganize expect…
Anrufliste Jun 3, 2024
7f0e476
Adapted 115 Goverment shor code, which is different to 110 & 112 shor…
Anrufliste Jun 3, 2024
2d1afff
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 3, 2024
3fa14e2
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 4, 2024
0995185
Adding todo in Validation Code to support not yet supported PhoneNumb…
Anrufliste Jun 4, 2024
5203340
Update Comments on 110 & 112 & 115 number checks to explain reason an…
Anrufliste Jun 8, 2024
2795da5
Adding Validation test for 116xxx social service short codes. Adaptin…
Anrufliste Jun 9, 2024
e153c1b
Use PhoneLib 8.13.39 and prepare release (#70)
Anrufliste Jun 14, 2024
39e7232
Starting Snapshot 1.2.5 (#71)
Anrufliste Jun 15, 2024
7f8726f
Issue for +49115 resubmitted
Anrufliste Jun 21, 2024
40a5013
Adding Validation test for 118(y)xx call assitant. Adapting Validatio…
Anrufliste Jun 23, 2024
b073729
Use PhoneLib 8.13.40 and prepare release (#72)
Anrufliste Jun 29, 2024
0565225
Starting Snapshot 1.2.6 (#73)
Anrufliste Jun 29, 2024
a11dfd3
libphonenumber 8.13.43 made change to German mobile 017x number range…
Anrufliste Sep 1, 2024
08fe3bb
Starting Snapshot 1.2.7 (#75)
Anrufliste Sep 1, 2024
d3ae0bc
Added reported issue to google for last versions test adaptions. (#76)
Anrufliste Sep 6, 2024
a6b4e04
Start Snapshot 1.2.8 (#77)
Anrufliste Sep 6, 2024
0d4d7b6
Prepare new class PhoneNumberValidator - currently just reusing Phone…
Anrufliste May 1, 2024
b21413c
Update copyright year of initial setting
Anrufliste May 1, 2024
9f1b5aa
Initial testing 5 separated cases
Anrufliste May 4, 2024
22f0319
Create Area Code Extractor (NDC) for Germany.
Anrufliste May 20, 2024
93c4805
Extend Number Plan to provide multi dimensional short code information.
Anrufliste May 20, 2024
5e1f063
Starting Validator.
Anrufliste May 20, 2024
a7366c8
Include Mobile NDCs into generator script for GermanAreaCodeExtractor…
Anrufliste May 21, 2024
f43537d
Short Code 110 and 112 are not valid start for fixed line numbers (ND…
Anrufliste May 22, 2024
b0f4461
Short Code 110 and 112 are not valid start for fixed line numbers (ND…
Anrufliste May 30, 2024
24c1479
Introducing INVALID_PREFIX_OF_SUBSCRIBER_NUMBER and reorganize expect…
Anrufliste Jun 3, 2024
7044eba
Adapted 115 Goverment shor code, which is different to 110 & 112 shor…
Anrufliste Jun 3, 2024
ccc65c9
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 3, 2024
13a7d1b
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 4, 2024
354a9af
Adding todo in Validation Code to support not yet supported PhoneNumb…
Anrufliste Jun 4, 2024
c7a1ec6
Update Comments on 110 & 112 & 115 number checks to explain reason an…
Anrufliste Jun 8, 2024
24540be
Adding Validation test for 116xxx social service short codes. Adaptin…
Anrufliste Jun 9, 2024
b6b9372
Issue for +49115 resubmitted
Anrufliste Jun 21, 2024
e9262be
Adding Validation test for 118(y)xx call assitant. Adapting Validatio…
Anrufliste Jun 23, 2024
c89d2ae
Use PhoneLib 8.13.46 and prepare release (#78)
Anrufliste Sep 25, 2024
6c816be
Start Snapshot 1.2.9 after release 1.2.8 (#79)
Anrufliste Sep 25, 2024
c2c4ada
Merge branch 'Validator' of https://github.com/telekom/phonenumber-no…
Anrufliste Sep 28, 2024
7112e1e
Use PhoneLib 8.13.47 and prepare release (#80)
Anrufliste Oct 4, 2024
740dfd7
Start Snapshot 1.2.10 after release 1.2.9 (#81)
Anrufliste Oct 4, 2024
4b0b2c0
Dependency updates >>> 1.3.0 (#82)
Anrufliste Oct 5, 2024
089d082
Prepare new class PhoneNumberValidator - currently just reusing Phone…
Anrufliste May 1, 2024
69723aa
Update copyright year of initial setting
Anrufliste May 1, 2024
6355b11
Initial testing 5 separated cases
Anrufliste May 4, 2024
c2f8c87
Create Area Code Extractor (NDC) for Germany.
Anrufliste May 20, 2024
2dc301f
Extend Number Plan to provide multi dimensional short code information.
Anrufliste May 20, 2024
472f50c
Starting Validator.
Anrufliste May 20, 2024
76d6e0a
Include Mobile NDCs into generator script for GermanAreaCodeExtractor…
Anrufliste May 21, 2024
f154231
Short Code 110 and 112 are not valid start for fixed line numbers (ND…
Anrufliste May 22, 2024
10b312e
Short Code 110 and 112 are not valid start for fixed line numbers (ND…
Anrufliste May 30, 2024
02b0c4d
Introducing INVALID_PREFIX_OF_SUBSCRIBER_NUMBER and reorganize expect…
Anrufliste Jun 3, 2024
567068d
Adapted 115 Goverment shor code, which is different to 110 & 112 shor…
Anrufliste Jun 3, 2024
994ad5f
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 3, 2024
cda0aa7
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 4, 2024
118baae
Adding todo in Validation Code to support not yet supported PhoneNumb…
Anrufliste Jun 4, 2024
6ac8c1d
Update Comments on 110 & 112 & 115 number checks to explain reason an…
Anrufliste Jun 8, 2024
7550ad4
Adding Validation test for 116xxx social service short codes. Adaptin…
Anrufliste Jun 9, 2024
fed7097
Issue for +49115 resubmitted
Anrufliste Jun 21, 2024
668144e
Adding Validation test for 118(y)xx call assitant. Adapting Validatio…
Anrufliste Jun 23, 2024
9de73db
Initial testing 5 separated cases
Anrufliste May 4, 2024
6d942c3
Initial testing 5 separated cases
Anrufliste May 4, 2024
fe590b5
Extend Number Plan to provide multi dimensional short code information.
Anrufliste May 20, 2024
2efe1d6
Short Code 110 and 112 are not valid start for fixed line numbers (ND…
Anrufliste May 30, 2024
9a62b8a
Adapted 115 Goverment shor code, which is different to 110 & 112 shor…
Anrufliste Jun 3, 2024
89416ff
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 3, 2024
91d05cc
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 4, 2024
93c5ca1
Update Comments on 110 & 112 & 115 number checks to explain reason an…
Anrufliste Jun 8, 2024
a71e245
Adding Validation test for 116xxx social service short codes. Adaptin…
Anrufliste Jun 9, 2024
ad9c050
Merging 1.3.1 with Validator A
Anrufliste Oct 5, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion REPORTED_ISSUES.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ However, it’s possible that this has caused confusion about which parts of the
This issue addresses special short codes used for phone number directory assistant services.
This issue has been resolved.

Google [fixed](https://github.com/google/libphonenumber/pull/2601/files#diff-1887949025d4940ce0f39cc4ba17666b5d93be2f143867b77c26bcddb36ac696R3400) ít with [8.12.21](https://github.com/google/libphonenumber/pull/2601) on 15.05.2024.

### 2021-03-25 - [Germany (DE, +49): 116xxx Short Number valid vs. assigned](https://issuetracker.google.com/issues/183669955)

This issue pertains to the EU-wide special social number short code definition. Although the regulation clearly defines a range, PhoneLib is not validating against that range, but against a list of currently assigned/operated numbers. At least for the German number space, as mentioned in the initial issue discussion (see first one above), the library is only partly or even completely checking the whole range in other EU number spaces.
Expand Down Expand Up @@ -48,4 +50,26 @@ BnetzA [described special case for NDC 212 and 621](https://www.bundesnetzagentu

We have provided Ludwighafen in our labeling data.

Google [fixed](https://github.com/google/libphonenumber/pull/3473/files#diff-db8e5b3fb2cb4a7ed9856289ea12d54947bfaa10549e6c1058fec7f3a1359dbbR3260) ít with [8.13.37](https://github.com/google/libphonenumber/pull/3473) on 15.05.2024.
Google [fixed](https://github.com/google/libphonenumber/pull/3473/files#diff-db8e5b3fb2cb4a7ed9856289ea12d54947bfaa10549e6c1058fec7f3a1359dbbR3260) ít with [8.13.37](https://github.com/google/libphonenumber/pull/3473) on 15.05.2024.

### 2024-05-22 - [Emergency Numbers must not be used with National Destination Code in Germany fixed line](https://issuetracker.google.com/issues/341947688)

BnetzA [described emergency short codes 110 & 112 as numbers without local NDC](https://www.bundesnetzagentur.de/SharedDocs/Downloads/DE/Sachgebiete/Telekommunikation/Unternehmen_Institutionen/Nummerierung/Rufnummern/np_nummernraum.pdf?__blob=publicationFile&v=1), since NDC is optional in fixed line, no number might start with those three digits (otherwise using such a number without NDC would trigger the emergency call). In mobile networks NDC is mandatory, so a number might start with those three digits, since NDC would be a prefix. Real live examples have been found.

Google acknowledged the issue, but marked it as "**Won't fix (Intended behavior)**" because "*We will definitely think about it but it is not a priority right now. Also we have already mentioned about the complexity and invalid or false positive numbers in our XML file of Germany https://github.com/google/libphonenumber/blob/30db8f67a1c06b3ab052497477be1d9f18312387/resources/PhoneNumberMetadata.xml#L8126*" on 27.05.2024

### 2024-06-08 - [Government Service Numbers may be used with National Destination Code in Germany fixed line, but subscriber numbers may not start with it](https://issuetracker.google.com/issues/345753226)

BnetzA [described government short codes 115](https://www.bundesnetzagentur.de/SharedDocs/Downloads/DE/Sachgebiete/Telekommunikation/Unternehmen_Institutionen/Nummerierung/Rufnummern/115/115_Nummernplan_konsolidiert.pdf?__blob=publicationFile&v=1), no number might start with those three digits (otherwise using such a number would trigger the short code). Furthermore the short code might be called with IDP and Country code (**+49115**) but from outside Germany and not from within - here the used region must have an influence on the evaluation.

Google since 09.07.2024, the Issue is not publicly accessible anymore - we wrote a [post in the Google discussion group](https://groups.google.com/g/libphonenumber-discuss/c/WQv244-PVmI).

### 2024-06-16 - [+49115 German Government short number with IDP+CC is only valid from outside Germany but not within (so IS_POSSIBLE_LOCAL_ONLY is also wrong)](https://issuetracker.google.com/issues/347356467)

Since the previous Issue "disappeared" without notice, we assume, it was structural too similar to the emergencies number issue and the reviewer did not recordnized the differences. So we reported the main difference - again and this time the issue is at least accepted. But the reviewer comment seems only to focus on the short number call-ability from outside the country and not that IDP+CC+115 must not be used from inside.

### 2024-09-03 - [German Mobile number length validation for range 17x inconsistently differentiated in 8.13.43](https://issuetracker.google.com/issues/364179199)

Previous to Version 8.13.43 any German number within the range 17x was identified valid for both length 10 & 11. Now the 11 length case (176) is differentiated, that 176 is not validated valid with 10 digits. But 170-175, 177-179 is still validated valid for both length, but should be only valid with length of 10.

Google stated it is aware and will bring changes after investigation that users are not unblock.
26 changes: 13 additions & 13 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<artifactId>normalizer</artifactId>
<name>Phonenumber Normalizer</name>
<description>Library to work with phonenumbers, especially to fix googles PhoneLib ignoring German Landline specifics.</description>
<version>1.2.3-SNAPSHOT</version>
<version>1.3.0</version>
<packaging>jar</packaging>
<url>https://github.com/telekom/phonenumber-normalizer</url>

Expand Down Expand Up @@ -86,7 +86,7 @@
<dependency>
<groupId>com.googlecode.libphonenumber</groupId>
<artifactId>libphonenumber</artifactId>
<version>8.13.37</version>
<version>8.13.47</version>
</dependency>

<dependency>
Expand All @@ -101,37 +101,37 @@
<dependency>
<groupId>org.springframework</groupId>
<artifactId>spring-context</artifactId>
<version>5.3.32</version>
<version>5.3.39</version>
</dependency>
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-lang3</artifactId>
<version>3.12.0</version>
<version>3.17.0</version>
</dependency>
<dependency>
<groupId>io.swagger</groupId>
<artifactId>swagger-annotations</artifactId>
<version>1.6.11</version>
<version>1.6.14</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
<version>2.15.2</version>
<version>2.18.0</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
<version>2.15.2</version>
<version>2.18.0</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<version>2.15.2</version>
<version>2.18.0</version>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
<version>2.0.7</version>
<version>2.0.16</version>
</dependency>
<dependency>
<groupId>javax.annotation</groupId>
Expand All @@ -150,13 +150,13 @@
<dependency>
<groupId>com.googlecode.libphonenumber</groupId>
<artifactId>geocoder</artifactId>
<version>2.231</version>
<version>2.241</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.codehaus.groovy</groupId>
<artifactId>groovy-all</artifactId>
<version>3.0.17</version>
<version>3.0.22</version>
<scope>test</scope>
<type>pom</type>
<exclusions>
Expand All @@ -175,14 +175,14 @@
<dependency>
<groupId>org.spockframework</groupId>
<artifactId>spock-core</artifactId>
<version>2.3-groovy-3.0</version>
<version>2.4-M4-groovy-3.0</version>
<scope>test</scope>
</dependency>
<!-- Replace Version 7.5 which has https://devhub.checkmarx.com/cve-details/CVE-2022-4065/?utm_source=jetbrains&utm_medium=referral&utm_campaign=idea&utm_term=maven -->
<dependency>
<groupId>org.testng</groupId>
<artifactId>testng</artifactId>
<version>7.8.0</version>
<version>7.10.2</version>
<scope>test</scope>
</dependency>
<!--Replaces Version 3.5.1 which has https://devhub.checkmarx.com/cve-details/CVE-2007-2379/?utm_source=jetbrains&utm_medium=referral&utm_campaign=idea -->
Expand Down
Loading
Loading