Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing license to test-utils crate #657

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

h7kanna
Copy link
Contributor

@h7kanna h7kanna commented Dec 12, 2023

What was changed

Added license to test-utils crate to 'cargo-deny' failures

Why?

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@h7kanna h7kanna requested a review from a team as a code owner December 12, 2023 22:52
@cretz
Copy link
Member

cretz commented Dec 13, 2023

Can we instead have all just refer to the license at the root?

@h7kanna
Copy link
Contributor Author

h7kanna commented Dec 13, 2023

Yes with license = { workspace = true }

@cretz
Copy link
Member

cretz commented Dec 13, 2023

@Sushisource - is it ok if we do that in each crate and remove all the LICENSE.txt files but the one in the root? Also, can we remove the unnecessary opening line on the root LICENSE.txt? It seems to be preventing GitHub from recognizing it's MIT for repo-metadata purposes.

@Sushisource
Copy link
Member

Sure, we can use one shared one and get rid of the line at the top.

Add missing license to test-utils crate

t
@h7kanna
Copy link
Contributor Author

h7kanna commented Dec 14, 2023

Ok, made the required changes

Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks!

@Sushisource Sushisource enabled auto-merge (squash) December 14, 2023 18:57
@Sushisource Sushisource merged commit 3c724a0 into temporalio:master Dec 14, 2023
6 checks passed
@h7kanna h7kanna deleted the test-utils-license branch December 14, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants