Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't request eager activities when task queue throttle is set #845

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

Sushisource
Copy link
Member

What was changed

See title

Why?

Server doesn't properly count them towards rate limits, so we are disabling for now.

Checklist

  1. Closes [Feature Request] Disable eager activities if task queue rate limits is set #840

  2. How was this tested:
    Added unit test

  3. Any docs updates needed?

@Sushisource Sushisource requested a review from a team as a code owner November 21, 2024 01:32
@Sushisource Sushisource enabled auto-merge (squash) November 21, 2024 16:51
@Sushisource Sushisource merged commit 6155b09 into master Nov 21, 2024
6 checks passed
@Sushisource Sushisource deleted the disable-eager-on-throttled-tq branch November 21, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Disable eager activities if task queue rate limits is set
2 participants