Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete references to never-constructed UpdateRejected event #6715

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dandavison
Copy link
Contributor

Delete references to the "UpdateRejected" event. It's never constructed by the server, and it makes sense to delete references to it from our codebases, seeing as lack of the event is a key premise of update that we have no plans to change.

Not tested. Not a hotfix candidate.

Copy link
Member

@bergundy bergundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, was this ever constructed in a previous implementation of the server? If it was, are we okay with dropping support for these messages and events?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants