PauseActivity implementation #6752
Open
+3,835
−3,476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ychebotarev
force-pushed
the
y_pause
branch
2 times, most recently
from
dbfec0c
to
9fb63b2
Compare
bergundy
reviewed
Nov 13, 2024
proto/internal/temporal/server/api/historyservice/v1/request_response.proto
Show resolved
Hide resolved
|
This is also missing functional and XDC tests. Can come in a followup PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add PuaseActivity API implementation
Why?
Working on activity API
How did you test it?
Add basic unit tests. Func tests will come later.