Add GetFrontendHostPort() method to TestServer

[laouji]

What changed?

Added a GetFrontendHostPort() method to the TestServer

Why?

For situations where you want to know the port that the test server is running on outside of typical use of client.Client

How did you test it?

Tested locally

Potential risks

None

Documentation

there is currently no documentation for TestServer aside from inline comments

Is hotfix candidate?

no

[CLAassistant]

All committers have signed the CLA.

[bergundy]

Thanks!

I'm wondering what's your use case? You might be better off using https://pkg.go.dev/go.temporal.io/[email protected]/testsuite#StartDevServer instead.

[bergundy]

The Go convention is to not use Get prefixes for getters. I see we've already violated that in this file so I'd accept your change as-is.

Suggested change

	// GetFrontendHostPort returns the host:port for this server.
	//
	// When constructing a Temporal client from within the same process,
	// GetDefaultClient or NewClientWithOptions should be used instead.
	func (ts *TestServer) GetFrontendHostPort() string {
	// FrontendHostPort returns the host:port for this server.
	//
	// When constructing a Temporal client from within the same process,
	// GetDefaultClient or NewClientWithOptions should be used instead.
	func (ts *TestServer) FrontendHostPort() string {

[laouji]

Yes, I stuck with the Get prefix for consistency within the package. If you prefer no Get prefix so that the interface is more similar to the DevServer, we could do that instead though.

[laouji]

@bergundy thanks for the review. I am using this TestServer for end to end testing, but my project setup involves passing the temporal host:port as a command line argument to the process that will instantiate the temporal client.

[bergundy]

@laouji, why not use the dev server utility I linked from the SDK package instead of taking dependency on the server as a library?

[laouji]

@bergundy the DevServer won't not work for my use-case, but it seemed a bit clunkier to add a network call to download the binary in my CI, when I could just instantiate a TemporalLite server in my code
https://github.com/temporalio/sdk-go/blob/master/testsuite/devserver.go#L201

I can play around with preinstalling the executable, if that's the recommended way to end-to-end test, though!