Return StartOutcome from Workflow Start #6795
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanos
commented
Nov 11, 2024
Comment on lines
-162
to
-170
| startOpResp := &historyservice.ExecuteMultiOperationResponse_Response{ | ||
| Response: &historyservice.ExecuteMultiOperationResponse_Response_StartWorkflow{ | ||
| StartWorkflow: &historyservice.StartWorkflowExecutionResponse{ | ||
| RunId: currentWorkflowLease.GetContext().GetWorkflowKey().RunID, | ||
| Started: false, | ||
| }, | ||
| }, | ||
| } | ||
|
|
stephanos
force-pushed
the
uws-starttype
branch
3 times, most recently
from
68c7569
to
eca6f1b
Compare
stephanos
force-pushed
the
uws-starttype
branch
from
eca6f1b
to
fe7d5ee
Compare
stephanos
commented
Nov 11, 2024
| return nil, startOutcome, newMultiOpError(err, | ||
| serviceerror.NewUnavailable("Workflow could not be started as it is already running")) | ||
| case startworkflow.StartDeduped: | ||
| panic("unreachable") |
There was a problem hiding this comment.
This will be used in the follow-up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Depends on #6795
What changed?
Introducing a new StartOutcome type. It signals the kind of start that was performed.
I considered various other options (like sentinel error types and adding a new field to the proto), but then decided on this.
Why?
This is needed for making Terminate-Existing work, since there it's important to distinguish between "deduped" and "reused".
See #6783
How did you test it?
Potential risks
Documentation
Is hotfix candidate?