Invalid history client cache #6802
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
reviewed
Nov 13, 2024
service/frontend/admin_handler.go
Outdated
| var suErr *serviceerror.Unavailable | ||
| if errors.As(err, &solErr) || errors.As(err, &suErr) { | ||
| ctx, cl := context.WithTimeout(context.Background(), 2*time.Second) | ||
| adh.historyClient.DescribeHistoryHost(ctx, &historyservice.DescribeHistoryHostRequest{ShardId: serverClusterShardID.ShardID}) |
There was a problem hiding this comment.
curious why this is not working. #6482
There was a problem hiding this comment.
Because client.StreamWorkflowReplicationMessages just to establish the stream connection. Data exchange happened when Recv() is called, and that is the time we got ShardOwnershipLost error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks
Documentation
Is hotfix candidate?