Disable gotestsum rerun #6808
Open
Disable gotestsum rerun #6808
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
approved these changes
Nov 13, 2024
stephanos
force-pushed
the
revert-retries
branch
from
1f712e4
to
f0ba1fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Disable
gotestsumre-runs.Why?
gotestsumhas a bug that reports test failures with exit code 0, making the GHA job succeed.See gotestyourself/gotestsum#423
How did you test it?
Test failure results in GHA job failure.
Potential risks
Documentation
Is hotfix candidate?