Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Scheduled Actions] bump scheduler version to ActionResultIncludesStatus #6811

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Scheduled Actions] bump scheduler version to ActionResultIncludesStatus #6811

wants to merge 2 commits into from
+23 −26

Conversation

lina-temporal
Copy link
Contributor

What changed?

  • Bumped the scheduler's version to ActionResultIncludesStatus, and removed a few TODOs from tests.

Why?

  • Rolling out ActionResultIncludesStatus. This will also roll out AccurateFutureActionTimes (apologies for batching).

How did you test it?

  • Backwards/forwards compatibility has been previously tested with TestReplays.

Potential risks

  • we break scheduled actions and have to roll back the version flag. We've tested rollback with a replay test.

Documentation

  • Docs are already in place (API docs)

Is hotfix candidate?

  • No

@lina-temporal lina-temporal requested a review from a team as a code owner November 13, 2024 21:40
dnr
dnr approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@dnr dnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this will go in 1.26.2.. we should do a 1.25.3 patch with #6665 to support downgrades

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnr dnr dnr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lina-temporal @dnr