Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json to resolve #8186 #8256

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

PrafulB
Copy link

@PrafulB PrafulB commented Apr 23, 2024

Updated the version of the tfjs-core dependency in tfjs-automl to resolve the ReferenceError when run from within a web worker. More info in #8186 .

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.

tfjs v4.0+ solves issue tensorflow#6922 which caused it to not be usable in web workers. tfjs-automl still used v3.9.0 . This fork updates it to 4.9.0+ , same as in its devDependencies.
Updated the version of the tfjs-core dependency in tfjs-automl to resolve the ReferenceError when run from within a web worker.
Copy link

google-cla bot commented Apr 23, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@@ -60,6 +60,6 @@
"peerDependencies": {
"@tensorflow/tfjs-backend-webgl": "^3.9.0",
"@tensorflow/tfjs-converter": "^3.9.0",
"@tensorflow/tfjs-core": "^3.9.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update all packages to the same version. thanks

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing the PR @pyu10055 . I've updated all dependency versions to the latest release 4.19.0 . Ran the tests locally and they all passed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review again when you can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants