Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for availability zone rebalancing (#262) #263

Conversation

keisukematsuda19921106
Copy link

Description

This PR aims to add support for availability zone rebalancing in the services.

References

Motivation and Context

Fixes : #262

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

rmolson and others added 8 commits November 29, 2024 14:37
…odules#243)

* allow a path on aws_iam_policy.task_exec

* feat: allowing an IAM Path for task_exec policy

* pre-commit

* updated terraform-docs localy

* fix: for wrappers pre-commit hook
* Add ALB endpoint to outputs - this makes it easier to test for successful deployment

* fix trailing whitespace

* update README to conform with conventions

* Add ALB endpoint to outputs - this makes it easier to test for successful deployment

* EOF fix

* updates in response to bryantbiggs review

* docs updates to go with CR feedback

---------

Co-authored-by: Seth Eliot <[email protected]>
@keisukematsuda19921106
Copy link
Author

@antonbabenko @barryib @bryantbiggs @dynamike @magreenbaum @nitrocode

Hi There!
May I get a review and hopefully a merge?

@bryantbiggs
Copy link
Member

this would required v5 of the provider hashicorp/terraform-provider-aws#40225 which means its a breaking change and instead go into #217

@keisukematsuda19921106
Copy link
Author

@bryantbiggs

thank you for you reaction!
Should I change the target branch to wip/v6?

@bryantbiggs
Copy link
Member

yes please

@keisukematsuda19921106 keisukematsuda19921106 changed the base branch from master to wip/v6 March 19, 2025 01:56
CHANGELOG.md Outdated
@@ -2,6 +2,18 @@

All notable changes to this project will be documented in this file.

## [5.12.0](https://github.com/terraform-aws-modules/terraform-aws-ecs/compare/v5.11.4...v5.12.0) (2024-11-29)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changelog is automatically generated on release, please revert this

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

cluster_arn = module.ecs_cluster.arn
name = "${local.name}-standalone"
cluster_arn = module.ecs_cluster.arn
create_service = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

@keisukematsuda19921106
Copy link
Author

@bryantbiggs

I'm sorry.

When I changed the branch to merge from master to wip/v6, I made an unintended change, so I created a new pull request. I will close this one, so please check it out.

New PR : #269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Availability Zone Rebalancing Input
6 participants