-
-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for availability zone rebalancing (#262) #263
feat: Add support for availability zone rebalancing (#262) #263
Conversation
…odules#243) * allow a path on aws_iam_policy.task_exec * feat: allowing an IAM Path for task_exec policy * pre-commit * updated terraform-docs localy * fix: for wrappers pre-commit hook
## [5.12.0](terraform-aws-modules/terraform-aws-ecs@v5.11.4...v5.12.0) (2024-11-29) ### Features * Allow task exec IAM policy to have an IAM path ([terraform-aws-modules#243](terraform-aws-modules#243)) ([c9dc889](terraform-aws-modules@c9dc889)) ### Bug Fixes * Update CI workflow versions to latest ([terraform-aws-modules#236](terraform-aws-modules#236)) ([fd0f0ec](terraform-aws-modules@fd0f0ec))
* Add ALB endpoint to outputs - this makes it easier to test for successful deployment * fix trailing whitespace * update README to conform with conventions * Add ALB endpoint to outputs - this makes it easier to test for successful deployment * EOF fix * updates in response to bryantbiggs review * docs updates to go with CR feedback --------- Co-authored-by: Seth Eliot <[email protected]>
@antonbabenko @barryib @bryantbiggs @dynamike @magreenbaum @nitrocode Hi There! |
this would required v5 of the provider hashicorp/terraform-provider-aws#40225 which means its a breaking change and instead go into #217 |
thank you for you reaction! |
yes please |
CHANGELOG.md
Outdated
@@ -2,6 +2,18 @@ | |||
|
|||
All notable changes to this project will be documented in this file. | |||
|
|||
## [5.12.0](https://github.com/terraform-aws-modules/terraform-aws-ecs/compare/v5.11.4...v5.12.0) (2024-11-29) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the changelog is automatically generated on release, please revert this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
cluster_arn = module.ecs_cluster.arn | ||
name = "${local.name}-standalone" | ||
cluster_arn = module.ecs_cluster.arn | ||
create_service = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
15d75ae
to
b401c84
Compare
I'm sorry. When I changed the branch to merge from master to wip/v6, I made an unintended change, so I created a new pull request. I will close this one, so please check it out. New PR : #269 |
Description
This PR aims to add support for availability zone rebalancing in the services.
References
Motivation and Context
Fixes : #262
Breaking Changes
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request