feat: Add support for availability zone rebalancing (#262) #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odules#243) * allow a path on aws_iam_policy.task_exec * feat: allowing an IAM Path for task_exec policy * pre-commit * updated terraform-docs localy * fix: for wrappers pre-commit hook
## [5.12.0](terraform-aws-modules/terraform-aws-ecs@v5.11.4...v5.12.0) (2024-11-29) ### Features * Allow task exec IAM policy to have an IAM path ([terraform-aws-modules#243](terraform-aws-modules#243)) ([c9dc889](terraform-aws-modules@c9dc889)) ### Bug Fixes * Update CI workflow versions to latest ([terraform-aws-modules#236](terraform-aws-modules#236)) ([fd0f0ec](terraform-aws-modules@fd0f0ec))
* Add ALB endpoint to outputs - this makes it easier to test for successful deployment * fix trailing whitespace * update README to conform with conventions * Add ALB endpoint to outputs - this makes it easier to test for successful deployment * EOF fix * updates in response to bryantbiggs review * docs updates to go with CR feedback --------- Co-authored-by: Seth Eliot <[email protected]>
|
@antonbabenko @barryib @bryantbiggs @dynamike @magreenbaum @nitrocode Hi There! |
|
this would required v5 of the provider hashicorp/terraform-provider-aws#40225 which means its a breaking change and instead go into #217 |
|
thank you for you reaction! |
|
yes please |
bryantbiggs
reviewed
Mar 19, 2025
CHANGELOG.md
Outdated
| @@ -2,6 +2,18 @@ | |||
|
|
|||
| All notable changes to this project will be documented in this file. | |||
|
|
|||
| ## [5.12.0](https://github.com/terraform-aws-modules/terraform-aws-ecs/compare/v5.11.4...v5.12.0) (2024-11-29) | |||
There was a problem hiding this comment.
the changelog is automatically generated on release, please revert this
bryantbiggs
reviewed
Mar 19, 2025
| cluster_arn = module.ecs_cluster.arn | ||
| name = "${local.name}-standalone" | ||
| cluster_arn = module.ecs_cluster.arn | ||
| create_service = false |
keisukematsuda19921106
force-pushed
the
master
branch
from
15d75ae to
b401c84
Compare
3 tasks
|
I'm sorry. When I changed the branch to merge from master to wip/v6, I made an unintended change, so I created a new pull request. I will close this one, so please check it out. New PR : #269 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add support for availability zone rebalancing in the services.
References
Motivation and Context
Fixes : #262
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request