feat: Change to managed IAM policy for ecs tasks with path attrribute support over inline role policy #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odules#243) * allow a path on aws_iam_policy.task_exec * feat: allowing an IAM Path for task_exec policy * pre-commit * updated terraform-docs localy * fix: for wrappers pre-commit hook
## [5.12.0](terraform-aws-modules/terraform-aws-ecs@v5.11.4...v5.12.0) (2024-11-29) ### Features * Allow task exec IAM policy to have an IAM path ([terraform-aws-modules#243](terraform-aws-modules#243)) ([c9dc889](terraform-aws-modules@c9dc889)) ### Bug Fixes * Update CI workflow versions to latest ([terraform-aws-modules#236](terraform-aws-modules#236)) ([fd0f0ec](terraform-aws-modules@fd0f0ec))
* Add ALB endpoint to outputs - this makes it easier to test for successful deployment * fix trailing whitespace * update README to conform with conventions * Add ALB endpoint to outputs - this makes it easier to test for successful deployment * EOF fix * updates in response to bryantbiggs review * docs updates to go with CR feedback --------- Co-authored-by: Seth Eliot <[email protected]>
…rribute support over inline role policy
feat! Change to use of managed IAM policy for ecs tasks with path attribute support over inline role policy
|
please fixup to go into the correct branch due to breaking change |
There are conflicts not related to my changes, all but the ones in modules/service/main.tf. Should I rather open a PR with changes based on the wip/v6 branch (and close this)? |
|
Closing this PR and opened a correct one for the correct breaking change branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following changes are proposed:
aws_iam_policyresource rather than the inline typeaws_iam_role_policypathof the ECS tasks policy.Motivation and Context
The change opens for more flexibility in the ECS tasks role for specifying the path of the policy.
This also aligns the ECS tasks role and policy with the same pattern that the existing role and policy for the ECS task execution role in the module.
Breaking Changes
Both cases applies both with or without the path configuration of the policy being set with the new variable
tasks_iam_policy_path.How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/completeproject deployed cleanly first, with later addition of ecs service variable input oftasks_iam_policy_pathprompting to take the changes into effect. The changes was deployed sucessfully.pre-commit run -aon my pull request