Replace better-color-tools with culori #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
2b551c2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fdc43dff.cobalt-ui.pages.dev |
| Branch Preview URL: | https://replace-better-color-tools.cobalt-ui.pages.dev |
🦋 Changeset detectedLatest commit: 2b551c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
drwpow
force-pushed
the
replace-better-color-tools
branch
3 times, most recently
from
d9209b2
to
04b012f
Compare
drwpow
force-pushed
the
replace-better-color-tools
branch
from
04b012f
to
2b551c2
Compare
drwpow
commented
Jul 28, 2023
| @@ -22,17 +22,17 @@ | |||
|
|
|||
| @supports (color: color(display-p3 1 1 1)) { | |||
| :root { | |||
| --ds-color-gray: color(display-p3 0.329412 0.278431 0.254902); | |||
| --ds-border: 1px solid color(display-p3 0.05098 0.011765 0); | |||
| --ds-color-gray: color(display-p3 0.32941176470588235 0.2784313725490196 0.2549019607843137); | |||
There was a problem hiding this comment.
🤔 I guess all the rounding I was doing was slowing my library down for no good reason
drwpow
commented
Jul 28, 2023
| --ds-color-blue: color(display-p3 0.129412 0.545098 1); | ||
| --ds-gradient: color(display-p3 0.129412 0.545098 1) 0%, color(display-p3 0.909804 0.352941 0.678431) 100%; | ||
| --ds-color-blue: color(display-p3 0.12941176470588237 0.5450980392156862 1); | ||
| --ds-gradient: color(display-p3 0.12941176470588237 0.5450980392156862 1) 0%, color(display-p3 0.9098039215686274 0.35294117647058826 0.6784313725490196) 100%; |
There was a problem hiding this comment.
FWIW I’m glad I maintained my own color science library for a bit. If no other reason than to be sure the colors were accurate. With thousands of ways to do things in culori, it’s so easy to produce the wrong colors when upconverting to P3, and it would take a while to realize it.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See note. Culori is a better color science option, but more importantly, is more performant.
Technically this increases the footprint of Cobalt by a few kB, but it’s still pretty stinkin’ small. And this runs in Node, so footprint isn’t nearly as much of a concern as production frontend code.