Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GJakutonis #55

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

GJakutonis #55

wants to merge 7 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 26, 2020

Some design assumptions:

  • token is short lived and can not be reused for a long period
  • servers list is short enough (up to 100 items) to be stored after each remote fetch as is and listed without filtering option

Some design simplifications (based on context of the task):

  • Application used as central access point for singleton Room database (could be injected)
  • All server records are swapped after each remote result (could be updated based on unique key)
  • Remote vs Local load logic in ViewModel layer (could be in injectable Repository)
  • Instrumentation tests only (could be some unit tests for Repository, see point above)
  • Backend SSL certificate is verified by well known CA and there is no need to limit acceptable certificates (could be additional work on OkHttp client)
  • Proguard turned off
  • Remote logging and tracking not applied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant