Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support TinyGo SDK for extension toolkit #104

Merged
merged 43 commits into from
Mar 15, 2021
Merged

Support TinyGo SDK for extension toolkit #104

merged 43 commits into from
Mar 15, 2021

Conversation

mathetake
Copy link
Member

@mathetake mathetake commented Sep 21, 2020 •
edited
Loading

resolves #101

@mathetake mathetake force-pushed the tinygo-extension branch 2 times, most recently from 5f21409 to 44281c1 Compare September 21, 2020 02:13
@mathetake mathetake force-pushed the tinygo-extension branch 9 times, most recently from 5c60724 to 4abe3c9 Compare September 22, 2020 07:12
@mathetake
Copy link
Member Author

Blocker: I would like to use wasi target of TinyGo which is yet to be merged to upstream (and I hope it will be merged soon)

@mathetake
Copy link
Member Author

mathetake commented Sep 29, 2020 •
edited
Loading

According to the discussion with @lizan, I decided to use my fork branch of TinyGo which supports WASI target: https://github.com/mathetake/tinygo/tree/non-js-wasm

need to fix examples to use WASI target

@mathetake
Copy link
Member Author

too heavy to build LLVM....

@mathetake mathetake mentioned this pull request Sep 29, 2020
Merged
3 tasks
@mathetake mathetake self-assigned this Sep 29, 2020
@mathetake mathetake added the enhancement New feature or request label Sep 29, 2020
@mathetake
Copy link
Member Author

tinygo-org/tinygo#1373 was merged finally so I use that nightly docker image for the extension builder's base

@mathetake mathetake force-pushed the tinygo-extension branch 2 times, most recently from 5eda64b to 9352958 Compare September 30, 2020 04:58
@mathetake mathetake marked this pull request as ready for review September 30, 2020 05:46
yskopets
yskopets reviewed Oct 1, 2020
View reviewed changes
test/e2e/getenvoy_extension_test_test.go Outdated Show resolved Hide resolved
test/e2e/getenvoy_extension_run_test.go Outdated Show resolved Hide resolved
test/e2e/getenvoy_extension_init_test.go Outdated Show resolved Hide resolved
test/e2e/getenvoy_extension_examples_test.go Outdated Show resolved Hide resolved
test/e2e/getenvoy_extension_build_test.go Outdated Show resolved Hide resolved
data/extension/init/templates/tinygo/envoy.filters.http/default/go.mod Outdated Show resolved Hide resolved
data/extension/init/templates/tinygo/envoy.filters.http/default/main.go Outdated Show resolved Hide resolved
data/extension/init/templates/tinygo/envoy.filters.http/default/main.go Outdated Show resolved Hide resolved
data/extension/init/templates/tinygo/envoy.filters.http/default/main.go Outdated Show resolved Hide resolved
data/extension/init/templates/tinygo/envoy.filters.http/default/main.go Show resolved Hide resolved
@mathetake mathetake mentioned this pull request Oct 2, 2020
Merged
@mathetake
Copy link
Member Author

@yskopets thanks for review and I reflected your comments except the SDK specific ones.

I'm going to refactor the SDK here tetratelabs/proxy-wasm-go-sdk#68

@mathetake mathetake mentioned this pull request Oct 5, 2020
Merged
@mathetake
Copy link
Member Author

@yskopets Thanks for the detailed review. I just did a bunch of refactoring in the SDK side, and I believe all your comments are addressed. PTAL!

@mathetake
Remove left 'exec'
2a300e9 
Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake
Remove unnecessary rm in clean command
b1b223d 
Signed-off-by: Takeshi Yoneda <[email protected]>
yskopets
yskopets reviewed Mar 10, 2021
View reviewed changes
Copy link
Member

@yskopets yskopets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry. One more round.

data/extension/init/templates/tinygo/envoy.access_loggers/default/main.go Outdated Show resolved Hide resolved
data/extension/init/templates/tinygo/envoy.access_loggers/default/main.go Outdated Show resolved Hide resolved
data/extension/init/templates/tinygo/envoy.access_loggers/default/main.go Outdated Show resolved Hide resolved
data/extension/init/templates/tinygo/envoy.access_loggers/default/main_test.go Show resolved Hide resolved
data/extension/init/templates/tinygo/envoy.access_loggers/default/go.mod Outdated Show resolved Hide resolved
data/extension/init/templates/tinygo/envoy.access_loggers/default/go.sum Show resolved Hide resolved
data/extension/init/templates/tinygo/envoy.filters.http/default/main.go Outdated Show resolved Hide resolved
data/extension/init/templates/tinygo/envoy.filters.network/default/main.go Outdated Show resolved Hide resolved
images/extension-builders/tinygo/Dockerfile Outdated Show resolved Hide resolved
data/extension/init/templates/tinygo/envoy.filters.network/default/main_test.go Outdated Show resolved Hide resolved
@mathetake mathetake requested a review from yskopets March 10, 2021 04:55
@mathetake
Re: fix entrypoint
f960379 
Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake
Revert: add go.sum
23e8fbc 
Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake
Revert debug code
7443281 
Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake
Copy link
Member Author

looks like we have reached the dockehub limit...

yskopets
yskopets reviewed Mar 11, 2021
View reviewed changes
Copy link
Member

@yskopets yskopets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, almost there. Some minor action points.

data/extension/init/templates/tinygo/envoy.access_loggers/default/go.sum Show resolved Hide resolved
data/extension/init/templates/tinygo/envoy.filters.network/default/main_test.go Outdated Show resolved Hide resolved
data/extension/init/templates/tinygo/envoy.access_loggers/default/go.mod Outdated Show resolved Hide resolved
data/extension/init/templates/tinygo/envoy.filters.http/default/go.mod Outdated Show resolved Hide resolved
data/extension/init/templates/tinygo/envoy.filters.network/default/go.mod Outdated Show resolved Hide resolved
images/extension-builders/tinygo/Dockerfile Show resolved Hide resolved
images/extension-builders/tinygo/commands.sh Show resolved Hide resolved
images/extension-builders/tinygo/Dockerfile Show resolved Hide resolved
data/extension/init/templates/tinygo/envoy.filters.network/default/main_test.go Show resolved Hide resolved
pkg/extension/workspace/toolchain/builtin/default_config.go Outdated Show resolved Hide resolved
@mathetake
Add .gitignore, and set extension name in go.mod
45a02f3 
Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake
default output to build/extension.wasm
b9024b0 
Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake
Update SDK: fix error
436d507 
Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake
Fix permission on host
b485f05 
Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake
Fix unittest
5ce9aa6 
Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake
Fix comment
b3c33e1 
Signed-off-by: Takeshi Yoneda <[email protected]>
yskopets
yskopets approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@yskopets yskopets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you!

Sorry that it took long. My only goal here is to make sure that extension development is logical from a user perspective.

The next step is to add a tutorial similar to https://www.getenvoy.io/tutorials/getting-started-http-filter-rust/

data/extension/init/templates/tinygo/envoy.access_loggers/default/main_test.go Show resolved Hide resolved
data/extension/init/templates/tinygo/envoy.access_loggers/default/main_test.go Show resolved Hide resolved
images/extension-builders/tinygo/commands.sh Outdated Show resolved Hide resolved
@mathetake
Copy link
Member Author

@yskopets Thanks a lot Yaro! Now the SDK becomes much better than before thanks to your review 👍 I'm going to merge this after I release v0.1.0 of SDK.

@mathetake
Update SDK
9715e55 
Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake mathetake merged commit a331da7 into master Mar 15, 2021
@mathetake mathetake deleted the tinygo-extension branch March 15, 2021 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yskopets yskopets yskopets approved these changes

@nullpo-head nullpo-head nullpo-head approved these changes

@lizan lizan Awaiting requested review from lizan

@musaprg musaprg Awaiting requested review from musaprg

Assignees

@mathetake mathetake

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Go SDK Support for GetEnvoy Extension Toolkit
4 participants
@mathetake @lizan @nullpo-head @yskopets