Delete Item #29
Merged
Delete Item #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dow for the user upon deleting item. Filled out deleteItem function in firebase Co-authored-by: EmmaBin <[email protected]>
|
Visit the preview URL for this PR (updated for commit 28ab926): https://tcl-76-smart-shopping-list--pr29-mp-eb-delete-item-hsao1ss1.web.app (expires Tue, 24 Sep 2024 17:54:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 512b1a88be8ae05fd3e727b99332819df760271d |
arandel1
reviewed
Sep 17, 2024
sar-mko
approved these changes
Sep 19, 2024
| const [checked, setChecked] = useState(false); | ||
|
|
||
| const handleDelete = async () => { | ||
| try { | ||
| if (window.confirm(`Are you sure you want to delete ${name}?`)) { |
There was a problem hiding this comment.
I like the check here :) and the use of async/await
nathanejbrown
approved these changes
Sep 19, 2024
mentalcaries
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added delete button and implemented a function. Created a confirm window for the user upon deleting item. Filled out deleteItem function in firebase
The code adds a delete button and
deleteItemfunction as well as a prompt asking if the user would like to delete the item. We learned more about how our firebase db structure and layers work.Related Issue
closes #12
Acceptance Criteria
ListItemcomponent renders a button that allows the user to delete an item from their list when clickeddeleteItemfunction inapi/firebase.jshas been filled out, and deletes the item from the Firestore databaseType of Changes
featureAfter
Testing Steps / QA Criteria