-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relocate Share List func to modal + navigation to lists from Home + styled Home components #38
Conversation
Visit the preview URL for this PR (updated for commit 759e80b): https://tcl-79-smart-shopping-list--pr38-refactor-homepage-fj2gxrnh.web.app (expires Sun, 13 Oct 2024 12:41:29 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d91d9ddbda780208241c52942f544acf8e81407a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the design notes from marcia it looks good to me great work! 👏
Description
The share list functionality has been moved to a modal, which opens when the share button next to each list is clicked.
When a list name is clicked, the site navigates to the list view for that specific list.
Components visible from the home page have been styled to match Figma (as much as I could).
Related Issue
Closes #32
Acceptance Criteria
SingleList
component renders a button that allows the user to open a modal when clicked.SingleList
component renders a clickable list name, which navigates to that list's view.SingleList
component renders a delete list button that does nothing (for now :))Type of Changes
enhancement
Updates
Before
After
Testing Steps / QA Criteria
git pull
andgit checkout refactor_homepage
npm start
.