Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate Share List func to modal + navigation to lists from Home + styled Home components #38

Merged
merged 9 commits into from
Oct 6, 2024

Conversation

Wyna-7
Copy link
Collaborator

@Wyna-7 Wyna-7 commented Oct 4, 2024

Description

The share list functionality has been moved to a modal, which opens when the share button next to each list is clicked.
When a list name is clicked, the site navigates to the list view for that specific list.
Components visible from the home page have been styled to match Figma (as much as I could).

Related Issue

Closes #32

Acceptance Criteria

  • Each SingleList component renders a button that allows the user to open a modal when clicked.
  • The modal allos the user to share the list with another user by filling and submitting a form.
  • Each SingleList component renders a clickable list name, which navigates to that list's view.
  • - [x] Each SingleList component renders a delete list button that does nothing (for now :))

Type of Changes

enhancement

Updates

Before

After

image
image

Testing Steps / QA Criteria

  • Do a git pull and git checkout refactor_homepage
  • Open the homepage by running npm start.
  • The share list functionality should be in a modal, which opens clicking the share icon next to each list.
  • When clicking on a list name, the site should navigate to that list's view

Copy link

github-actions bot commented Oct 4, 2024

Visit the preview URL for this PR (updated for commit 759e80b):

https://tcl-79-smart-shopping-list--pr38-refactor-homepage-fj2gxrnh.web.app

(expires Sun, 13 Oct 2024 12:41:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d91d9ddbda780208241c52942f544acf8e81407a

Copy link
Collaborator

@marshjaja marshjaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! 🚀 I’ve made some suggested adjustments to align with the colour palette and design we chose on Figma.

There where a lot of file and I hope I didn't miss one😅
Please let me know if you have any questions

Screenshot 2024-10-05 at 13 49 04
Screenshot 2024-10-05 at 13 50 58

src/components/SingleList.jsx Outdated Show resolved Hide resolved
src/components/SingleList.jsx Outdated Show resolved Hide resolved
src/views/Home.jsx Outdated Show resolved Hide resolved
src/views/Home.jsx Outdated Show resolved Hide resolved
src/components/ShareModal.jsx Outdated Show resolved Hide resolved
src/components/CreateShoppingList.jsx Outdated Show resolved Hide resolved
src/components/CreateShoppingList.jsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@Hudamabkhoot Hudamabkhoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the design notes from marcia it looks good to me great work! 👏

@Wyna-7 Wyna-7 changed the base branch from main to feat/setup-tailwind-shadcn October 6, 2024 09:14
@marshjaja marshjaja merged commit 01dbba4 into feat/setup-tailwind-shadcn Oct 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the list sharing form to home page.
3 participants