Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moduleProductGrid – Adding Slug to Clean Data #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wkhearn
Copy link
Contributor

@wkhearn wkhearn commented Jun 16, 2020

This PR adds the moduleProductGrid slug to the data being cleaned and delivered for that module. This is needed to properly utilize the logic set up for the CLP (All Products) nav bar functionality.

More context:
The module slug is referenced in productGrid.js in the Wool & Oak repo on lines 390 and 510, which enables the sticky nav buttons to jump to the correct module. Without the js-${slug} ID, the CLP nav bar will always have to be manually coded.

Clean Data for moduleProductGrid currently:
Screen Shot 2020-06-16 at 2 34 56 PM

Screen Shot 2020-06-16 at 2 32 04 PM

Nav Bar handleJump logic:
Screen Shot 2020-06-16 at 2 33 28 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant