Unprivileged user kerberos #1571
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also grants passwordless sudo via the groupname, which defaults to the username if groupname is not specified.
wbclark
force-pushed
the
unprivileged_user_kerberos
branch
from
19106f6
to
8bc3978
Compare
ekohl
requested changes
Sep 1, 2022
| state: present | ||
| when: ansible_os_family == "Debian" | ||
|
|
||
| - name: "Copy Kerberos client config from Host" |
There was a problem hiding this comment.
This seriously feels out of scope for this role. Roles should be small and focused. When I read unprivileged_user I don't think it essentially means "reconfigure the whole system".
What I'd do is create a role to make the system a kerberos client, with an option to copy from the host. You can then combine those in a playbook. Composition is a great thing and playbooks are the right place for that.
There was a problem hiding this comment.
With the default parameter values, the behavior is exactly the same because none of the extra tasks here will run. But I don't mind extracting it out into a separate role to keep things organized.
|
Closing in favor of #1574 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #1570 and adds capabilities to optionally install kerberos client packages, copy kerberos configuration from the host system, and copy credential cache from the host system. These features are opt-in; they are disabled by default.