-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @simulacrum/cypress-auth0 package #114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome. I'll let Charles and Jacob do a more thorough review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move as much as we can into before
and beforeEach
hooks?
12f39a5
to
17084ce
Compare
8d6333e
to
dfb80bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other then the merge problems 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fd39a38
to
3e8808d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also went through and tried to get this working in the example branch, but was having issues with the wrap timing out. I am tempted to say it is a misconfiguration on my end though, and I think maybe we touch on these last things and merge it in. I can rebase my examples and try again.
@dagda1 need me to finish these things up? Let me know thoughts on these I can take make any adjustments if need be.
Also, side note, I don't see any destroying of simulations here, but I don't think we need to worry with the hash; they all get destroyed when the process finishes, right? Maybe file it under an "address in the future" consideration.
3e8808d
to
a3e3cc5
Compare
aa847ce
to
7856dfb
Compare
86ab761
to
3906a98
Compare
Motivation
Add a
@simulacrum/cypress-auth0
package that containslogIn
andlogOut
commandsApproach
Because we can start the simulacrum server with
npx
when #113 lands the cypress commands feel like they should be in their own separate package.The location and naming of things are open for debate but hopefully, the package itself is relatively simple.
TODO
createSimulation
idempotent, i.e. creating a simulation on the same port should not crash the whole simulation server.ClientMap