Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @simulacrum/cypress-auth0 package #114

Merged
merged 50 commits into from
Oct 13, 2021
Merged

Add @simulacrum/cypress-auth0 package #114

merged 50 commits into from
Oct 13, 2021

Conversation

dagda1
Copy link
Contributor

@dagda1 dagda1 commented Aug 4, 2021

Motivation

Add a @simulacrum/cypress-auth0 package that contains logIn and logOut commands

Approach

Because we can start the simulacrum server with npx when #113 lands the cypress commands feel like they should be in their own separate package.

The location and naming of things are open for debate but hopefully, the package itself is relatively simple.

TODO

  • Make createSimulation idempotent, i.e. creating a simulation on the same port should not crash the whole simulation server.
  • Fix logout, currently returns 500 and also make it idempotent so it does not fail if the scenario is not logged in.
  • enable error logging from simulacrum
  • Optional fix to provide a better way of maintaining state and remove the ugly ClientMap

@dagda1 dagda1 requested review from cowboyd, jbolda and taras August 4, 2021 13:19
Copy link
Member

@taras taras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. I'll let Charles and Jacob do a more thorough review.

Copy link
Member

@cowboyd cowboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move as much as we can into before and beforeEach hooks?

@dagda1 dagda1 force-pushed the add-cypress-integration branch 4 times, most recently from 12f39a5 to 17084ce Compare August 9, 2021 13:38
@dagda1 dagda1 force-pushed the add-cypress-integration branch from 8d6333e to dfb80bc Compare August 11, 2021 17:30
Copy link
Member

@taras taras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other then the merge problems 👍

Copy link
Member

@cowboyd cowboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dagda1 dagda1 force-pushed the add-cypress-integration branch from fd39a38 to 3e8808d Compare August 12, 2021 14:58
Copy link
Contributor

@jbolda jbolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also went through and tried to get this working in the example branch, but was having issues with the wrap timing out. I am tempted to say it is a misconfiguration on my end though, and I think maybe we touch on these last things and merge it in. I can rebase my examples and try again.

@dagda1 need me to finish these things up? Let me know thoughts on these I can take make any adjustments if need be.

Also, side note, I don't see any destroying of simulations here, but I don't think we need to worry with the hash; they all get destroyed when the process finishes, right? Maybe file it under an "address in the future" consideration.

@jbolda jbolda force-pushed the add-cypress-integration branch 11 times, most recently from aa847ce to 7856dfb Compare August 19, 2021 17:06
@dagda1 dagda1 force-pushed the add-cypress-integration branch from 86ab761 to 3906a98 Compare October 13, 2021 15:26
@dagda1 dagda1 merged commit c5a3bf3 into v0 Oct 13, 2021
@dagda1 dagda1 deleted the add-cypress-integration branch October 13, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants