Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove multi-role vestigial #151

Conversation

joshuagl
Copy link
Member

This is the change from #141 rebased after the bikeshed conversion.

mnm678
mnm678 previously approved these changes Mar 18, 2021
Copy link
Collaborator

@mnm678 mnm678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as long as we take into account @lukpueh's comment from #140 regarding changes to the draft branch

Signed-off-by: Trishank Karthik Kuppusamy <[email protected]>
@joshuagl joshuagl force-pushed the trishankatdatadog/remove-tap-3-vestigial branch from 671eb29 to 718f133 Compare May 27, 2021 09:27
@joshuagl
Copy link
Member Author

@mnm678 @trishankatdatadog please take a look. Thanks.

Copy link
Collaborator

@mnm678 mnm678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnm678
Copy link
Collaborator

mnm678 commented May 27, 2021

@trishankatdatadog, will this fix the workflow concern from #150?

@trishankatdatadog
Copy link
Member

@trishankatdatadog, will this fix the workflow concern from #150?

No, because this is a separate issue/concern.

@trishankatdatadog trishankatdatadog merged commit b6aee74 into theupdateframework:master May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants