actions: Update pinned requirements #544
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
jku and
kommendorkapten
as code owners
| @@ -55,7 +55,7 @@ google-auth==2.38.0 | |||
| # google-cloud-kms | |||
| google-cloud-kms==3.2.2 | |||
| # via securesystemslib | |||
| googleapis-common-protos==1.66.0 | |||
| googleapis-common-protos==1.67.0rc1 | |||
There was a problem hiding this comment.
always a good sign to get rc dependencies...
This might be a mistake in our update-pinned-deps: nothing else really changes so I did not expect this
There was a problem hiding this comment.
weirdly I don't get this same result locally
There was a problem hiding this comment.
Interesting. How do you want to proceed here?
There was a problem hiding this comment.
Not sure:
- I can see this happens only when the dependency (in two of our dependencies) is
googleapis-common-protos<2.0.0dev-- this seems weird but I'm not sure why this is related - I still have no idea why this only happens in GitHub Actions: locally I have the same Python version, same pip-tools version... I still can't reproduce
There was a problem hiding this comment.
Oh I got it now:
- pip 23.3 does not reproduce
- pip 25.0.1 does reproduce
There was a problem hiding this comment.
as pip devs pointed out, pip was just fixing the previous incorrect resolution.
Real issue is google libraries using "googleapis-common-protos<2.0.0dev" style requirements: I've filed this internally. For now we might have to do some manual fixes -- but we can let these collect for a week or two
There was a problem hiding this comment.
googleapis-common-protos made an actual release so this specific issue has gone away: it will appear again though
Note: close and reopen the PR to trigger CI.