Start linting with Zizmor #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This case is harmless but still makes sense to avoid bad habits.
Both actions and workflows get checked at the same time. * Add lint workflow: this did not quite fit in the normal test matrix since it needs GH_TOKEN (and because the dependencies are tracked separately) so I added a separate workflow * "tox -e lint-actions" works too (and this is included in "tox -m lint") although these miss a few checks because github token is not available * A few workflow issues found by zizmor are fixed as well
kommendorkapten
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actions: Start linting with zizmor
Both actions and workflows get linted at the same time.
tox -e lint-actionsworks (and is included intox -m lint) although these miss a few checks because github token is not available