Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SiweExternal Auth - Login through static React EOA #123

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Jan 17, 2025

Allows you to login to otherwise native-unavailable wallets such as Abstract Wallet & Coinbase Smart Wallet through a flow similar to OAuth, using SIWE.

Closes TOOL-3134
Related TOOL-3137


PR-Codex overview

This PR introduces support for a new authentication method called SiweExternal in the InAppWallet system. It enhances the wallet's capabilities to integrate with external sign-in processes, improving user authentication options.

Detailed summary

  • Added SiweExternal to AuthProvider enumeration.
  • Implemented SignInWithSiweRawAsync method in EmbeddedWallet.
  • Created PreAuth_SiweExternal and LoginWithSiweExternal methods in EcosystemWallet.
  • Updated IThirdwebWallet interface to expose properties and methods publicly.
  • Added ToString method in LoginPayloadData for JSON serialization.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Allows you to login to otherwise native-unavailable wallets such as Abstract Wallet & Coinbase Smart Wallet through a flow similar to OAuth, using SIWE.

Closes TOOL-3134
Related TOOL-3137
Copy link

linear bot commented Jan 17, 2025

@0xFirekeeper 0xFirekeeper merged commit b50e1ed into main Jan 17, 2025
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/siwe-external branch January 17, 2025 18:55
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.71%. Comparing base (0c94da4) to head (af9f663).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
Thirdweb/Thirdweb.Wallets/IThirdwebWallet.cs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
+ Coverage   76.68%   76.71%   +0.03%     
==========================================
  Files          28       28              
  Lines        4799     4802       +3     
  Branches      665      665              
==========================================
+ Hits         3680     3684       +4     
- Misses        945      946       +1     
+ Partials      174      172       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants