[SDK] Update implementation addr extraction logic #6093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 08cc489 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
size-limit report 📦
|
| @@ -54,5 +54,10 @@ export function extractMinimalProxyImplementationAddress( | |||
| return `0x${implementationAddress}`; | |||
| } | |||
|
|
|||
| if (bytecode.startsWith("0xef0100")) { | |||
joaquim-verges
approved these changes
Jan 29, 2025
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
packages/thirdweb/src/utils/bytecode/extractMinimalProxyImplementationAddress.ts
Show resolved
Hide resolved
github-actions
bot
added
Dashboard
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6093 +/- ##
==========================================
+ Coverage 56.90% 56.92% +0.02%
==========================================
Files 1155 1155
Lines 63916 63920 +4
Branches 5193 5195 +2
==========================================
+ Hits 36369 36388 +19
+ Misses 26821 26804 -17
- Partials 726 728 +2
*This pull request uses carry forward flags. Click here to find out more.
|
graphite-app bot
pushed a commit
that referenced
this pull request
Feb 3, 2025
TOOL-3258
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR introduces a patch related to EIP-7702 in the `thirdweb` package, specifically enhancing the functionality to extract minimal proxy implementation addresses from bytecode.
### Detailed summary
- Added a check for EIP-7702 compliance in the `extractMinimalProxyImplementationAddress.ts` file.
- Implemented logic to extract the implementation address from bytecode if it meets the specified conditions (length of 48 and starts with "0xef0100").
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
graphite-app
bot
force-pushed
the
yash/update-impl-addr-extraction
branch
from
27b35ec to
62f2cd9
Compare
graphite-app
bot
removed
the
merge-queue
kumaryash90
added
the
merge-queue
TOOL-3258
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR introduces support for EIP-7702 by adding functionality to extract the implementation address from a specific bytecode pattern. It includes a new utility function and a corresponding test case.
### Detailed summary
- Added EIP-7702 support in `extractMinimalProxyImplementationAddress.ts` to extract the implementation address from bytecode.
- Implemented a check for bytecode length and prefix.
- Added a test case in `extractMinimalProxyImplementationAddress.test.ts` to validate the new functionality.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
graphite-app
bot
force-pushed
the
yash/update-impl-addr-extraction
branch
from
7c4bf4a to
08cc489
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TOOL-3258
PR-Codex overview
This PR introduces support for extracting implementation addresses from bytecode that conforms to the EIP-7702 specification. It adds a new utility function and a corresponding test to ensure the functionality works as expected.
Detailed summary
extractMinimalProxyImplementationAddress.tsto handle EIP-7702 delegation designator.0xef0100.extractMinimalProxyImplementationAddress.test.tsto verify correct extraction of address from EIP-7702 bytecode.