Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] fix: Use default contract params with optional overrides #6581

Merged
merged 2 commits into from
Mar 30, 2025

Conversation

kumaryash90
Copy link
Member

@kumaryash90 kumaryash90 commented Mar 29, 2025


PR-Codex overview

This PR focuses on refactoring the way parameters are initialized and passed to the deployContractfromDeployMetadata function, enhancing the merging of constructor parameters for better clarity and maintainability.

Detailed summary

  • Changed initializeParams to merge deployMetadata.constructorParams and contractParams using the spread operator.
  • Changed implementationConstructorParams to merge deployMetadata.implConstructorParams and implementationConstructorParams using the spread operator.
  • Updated constructorParams to merge the result of getAllDefaultConstructorParamsForImplementation with processedImplParams using the spread operator.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@kumaryash90 kumaryash90 requested review from a team as code owners March 29, 2025 11:14
Copy link
Contributor

graphite-app bot commented Mar 29, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link

vercel bot commented Mar 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2025 0:39am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2025 0:39am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2025 0:39am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2025 0:39am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2025 0:39am

Copy link
Contributor

github-actions bot commented Mar 29, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.56 KB (0%) 952 ms (0%) 153 ms (+163.49% 🔺) 1.2 s
thirdweb (cjs) 127.31 KB (0%) 2.6 s (0%) 213 ms (+28.86% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 76 ms (+1546.79% 🔺) 188 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 22 ms (+896.65% 🔺) 32 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 106 ms (+613.56% 🔺) 493 ms

@kumaryash90 kumaryash90 changed the title Use default contract params with optional overrides [SDK] fix: Use default contract params with optional overrides Mar 29, 2025
Copy link

changeset-bot bot commented Mar 29, 2025

⚠️ No Changeset found

Latest commit: c50cede

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Mar 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.99%. Comparing base (ba92cd2) to head (c50cede).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6581   +/-   ##
=======================================
  Coverage   54.99%   54.99%           
=======================================
  Files         885      885           
  Lines       55503    55509    +6     
  Branches     3797     3794    -3     
=======================================
+ Hits        30522    30528    +6     
  Misses      24886    24886           
  Partials       95       95           
Flag Coverage Δ
packages 54.99% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
...rdweb/src/extensions/prebuilts/deploy-published.ts 86.25% <100.00%> (+0.26%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges merged commit 6dbed0d into main Mar 30, 2025
32 checks passed
@joaquim-verges joaquim-verges deleted the yash/use-default-params branch March 30, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants