-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] fix: Use default contract params with optional overrides #6581
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6581 +/- ##
=======================================
Coverage 54.99% 54.99%
=======================================
Files 885 885
Lines 55503 55509 +6
Branches 3797 3794 -3
=======================================
+ Hits 30522 30528 +6
Misses 24886 24886
Partials 95 95
🚀 New features to boost your workflow:
|
PR-Codex overview
This PR focuses on refactoring the way parameters are initialized and passed to the
deployContractfromDeployMetadata
function, enhancing the merging of constructor parameters for better clarity and maintainability.Detailed summary
initializeParams
to mergedeployMetadata.constructorParams
andcontractParams
using the spread operator.implementationConstructorParams
to mergedeployMetadata.implConstructorParams
andimplementationConstructorParams
using the spread operator.constructorParams
to merge the result ofgetAllDefaultConstructorParamsForImplementation
withprocessedImplParams
using the spread operator.