Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Fix secret key handling #6584

Merged
merged 1 commit into from
Mar 30, 2025
Merged

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 30, 2025


PR-Codex overview

This PR focuses on improving the handling of the secret key in the CLI for the thirdweb package, ensuring better user guidance when the key is not provided.

Detailed summary

  • Updated the error message in buildStylus function to specify that the secret key should be passed via the -k parameter.
  • Removed the line that splices the rest array in bin.ts after extracting the secret key.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Mar 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 30, 2025 10:44pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 30, 2025 10:44pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 30, 2025 10:44pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 30, 2025 10:44pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 30, 2025 10:44pm

Copy link

changeset-bot bot commented Mar 30, 2025

🦋 Changeset detected

Latest commit: 8c53239

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joaquim-verges joaquim-verges marked this pull request as ready for review March 30, 2025 22:36
@joaquim-verges joaquim-verges requested review from a team as code owners March 30, 2025 22:36
@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Mar 30, 2025
Copy link
Member Author

joaquim-verges commented Mar 30, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.56 KB (0%) 952 ms (0%) 203 ms (+148.1% 🔺) 1.2 s
thirdweb (cjs) 127.31 KB (0%) 2.6 s (0%) 255 ms (+6.4% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 82 ms (+1166.52% 🔺) 194 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 34 ms (+1352.84% 🔺) 44 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 99 ms (+356.28% 🔺) 486 ms

Copy link

codecov bot commented Mar 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.98%. Comparing base (a1d785b) to head (8c53239).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6584      +/-   ##
==========================================
- Coverage   54.99%   54.98%   -0.01%     
==========================================
  Files         885      885              
  Lines       55503    55503              
  Branches     3797     3794       -3     
==========================================
- Hits        30522    30518       -4     
- Misses      24886    24890       +4     
  Partials       95       95              
Flag Coverage Δ
packages 54.98% <ø> (-0.01%) ⬇️

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges merged commit 3d7c009 into main Mar 30, 2025
35 checks passed
@joaquim-verges joaquim-verges deleted the _CLI_Fix_secret_key_handling branch March 30, 2025 22:49
@joaquim-verges joaquim-verges mentioned this pull request Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant