Update MetaMaskWallet.cs for 5.15.1 #227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update modifies the Disconnect method in MetaMaskWallet.cs to address a key limitation in its previous implementation, particularly for WebGL environments. Previously, the Disconnect method performed a "soft disconnect." As a result, users were unable to switch wallets within the same MetaMask extension without first revoking permissions in the wallet. Upon reconnection, the system would automatically connect to the previously authorized wallet. The updated implementation ensures a more robust disconnection process, allowing users to seamlessly switch wallets within the MetaMask extension without the need for manual revocation. This enhancement improves user experience and aligns with expected wallet management functionality. - Why this change? The soft disconnect behavior created unnecessary friction for users, especially those needing to manage multiple wallets. By implementing a proper disconnect process, this update simplifies wallet switching and ensures greater flexibility for WebGL applications integrating MetaMask. Signed-off-by: tulfix <[email protected]>
Update MetaMaskWallet.cs for 5.15.1
Signed-off-by: tulfix <[email protected]>
Read/write tutorial
|
Hey I will ship the metamask changes myself directly and credit you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update MetaMaskWallet.cs for 5.15.1
This update modifies the Disconnect method in MetaMaskWallet.cs to address a key limitation in its previous implementation, particularly for WebGL environments.
Previously, the Disconnect method performed a "soft disconnect." As a result, users were unable to switch wallets within the same MetaMask extension without first revoking permissions in the wallet. Upon reconnection, the system would automatically connect to the previously authorized wallet.
The updated implementation ensures a more robust disconnection process, allowing users to seamlessly switch wallets within the MetaMask extension without the need for manual revocation. This enhancement improves user experience and aligns with expected wallet management functionality.
The soft disconnect behavior created unnecessary friction for users, especially those needing to manage multiple wallets. By implementing a proper disconnect process, this update simplifies wallet switching and ensures greater flexibility for WebGL applications integrating MetaMask.
PR-Codex overview
This PR focuses on enhancing the
Disconnectmethod in theMetaMaskWalletclass to properly revoke permissions from MetaMask. Additionally, it includes significant updates to the Unity scene and various UI components.Detailed summary
Disconnectmethod from returningTasktoasync Task.eth_accountspermissions inDisconnect.Scene_Playground.