Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update get_number_of_deaths to match changed FHI schema #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

update get_number_of_deaths to match changed FHI schema #13

wants to merge 2 commits into from

Conversation

minrk
Copy link

@minrk minrk commented Apr 29, 2021

  • includes use trees api to fetch github data #12 , needed to get full datafiles list
  • fhi no longer includes 'total' rows as of 2021-03-09, so drop totals when present and compute sums ourselves
  • fhi now publishes a 'latest' file, which should be ignored, but raised an error before
  • tweak how rows are appended (use date as index, only sort on save)

@minrk
use trees api to fetch github data
a1eca07 
contents api truncates to 1000 files, which means test data hasn't been updated since October

trees api is more tedious, but not truncated
@minrk
update get_number_of_deaths to match changed fhi schema
fe74351 
- fhi data files no longer include sums, so compute sums instead (dropping sums if found)
- use date as index in dataframe
@minrk
Copy link
Author

minrk commented Apr 29, 2021

Results can be seen in this commit

@minrk minrk mentioned this pull request Jan 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@minrk