Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove face4 #197

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

Remove face4 #197

wants to merge 34 commits into from

Conversation

brason
Copy link

@brason brason commented Mar 30, 2015

This removes all use of Face4, replaces UV with Vector2, adds RingGeometry, as well as updates some examples and adds a new one.

extrude
geometries_2
shapes

brason added 30 commits April 2, 2015 15:14
@brason
Update CircleGeometry
fe820e1
@brason
Update ConvexGeometry
2c208b0
@brason
Update CubeGeometry
bf998e6
@brason
Update CylinderGeometry
94e88c5
@brason
Update ExtrudeGeometry
0cfcc3c
@brason
Cleanup IcosahedronGeometry
ed67669
@brason
Update LatheGeometry
9aee3bc
@brason
Update ParametricGeometry and add factory constructors for creating d…
813d562 
…ifferent geometries
@brason
Update PlaneGeometry
85dac17
@brason
Replace UV in PolyhedronGeometry
ef0ae8e
@brason
Add RingGeometry
da2e55c
@brason
Update ShapeGeometry
e529e08
@brason
Update SphereGeometry
b5d0d55
@brason
Small adjustment to TextGeometry
f9fef0a
@brason
Update TorusGeometry
0836615
@brason
Update TorusKnotGeometry
a40645e
@brason
Update Shape
6a7fbfd
@brason
Add Curve.create for creating classes with custom getPoint function
73a06af
@brason
Add CurveExtras
4025dc2
@brason
Update TubeGeometry
2997e06
@brason
Update AxisHelper
8cc1015
@brason
Replace UV and add clone method to Geometry
4132e7c
@brason
Remove use of Face4 and fix variables using UV
038e7ea
@brason
Delete face4.dart, uv.dart and remove references
080dae5
@brason
Add reference to RingGeometry
0255e19
@brason
Replace UV in geometry_utils, projector and obj_loader
d557d3d
@brason
Update JSONLoader
3bad375
@brason
Update web_gl_geometry_shapes example
f510824
@brason
Delete outdated example
4da47c7
@brason
Add new webgl_geometries2 example
bfd52e2
@brason
Copy link
Author

brason commented Apr 7, 2015

/ping @johsin18 :)

@nelsonsilva
Copy link
Member

Thanks @brason
Looks like you did a lot of work ;)
Unfortunately I'd say there's too much going on for a single PR which makes it difficult to you review.
Can you break it down into smaller PRs with some more context info about the updates/new features (at least why they're something we want/need) ?
I'd say we're looking at at least four PRs: updates and cleanups, adding RingGeometry + samples, replacing UV with Vector 2 and removing Face4.
You can create a new branch from master, cherry pick some commits and push them to a new branch to open a new, smaller PR.

@brason
Copy link
Author

brason commented Apr 19, 2015

I feared you might say that :) I will get to it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brason @nelsonsilva