fix(fserver): only check if the last directory is Resources #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that the server could be started by the liveview server start command it's best to not assume we were given a valid path (although that probably is a safe assumption) and to just improve the existing check to only check if the last segment of the path is Resources rather than if it simply exists in the path Fixes TIMOB-28226
|
sgtcoolguy
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that the server could be started by the liveview server start command it's best to not assume
we were given a valid path (although that probably is a safe assumption) and to just improve the
existing check to only check if the last segment of the path is Resources rather than if it simply
exists in the path
Fixes TIMOB-28226