ensure survival vectors are unnamed for #1023 #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfrick
reviewed
Nov 13, 2023
There was a problem hiding this comment.
Good call on removing the names as close to the source as possible! The tests for the standalone functions are in extratests, could we add that one there as well? We can move them altogether if you think they should be in parsnip but for now I'd like to keep them in one place. The tests there also use interval and counting censoring, which led me to surface #1025.
topepo
added a commit
to tidymodels/extratests
that referenced
this pull request
Nov 14, 2023
topepo
added a commit
to tidymodels/extratests
that referenced
this pull request
Nov 14, 2023
topepo
added a commit
to tidymodels/extratests
that referenced
this pull request
Nov 14, 2023
* unit tests for tidymodels/parsnip#1024 * version skip for parsnip
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1023
See tidymodels/workflows#200 and tidymodels/extratests#110