Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

predict ordinal factors from ordinal regression models #1217

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Conversation

topepo
Copy link
Member

@topepo topepo commented Oct 25, 2024

Currently, we accidentally strip off the ordered element of factors when we make class predictions.

Relevant to #953

@topepo topepo marked this pull request as ready for review October 28, 2024 11:16
@topepo topepo requested a review from hfrick October 28, 2024 11:16
Copy link
Member

@hfrick hfrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@topepo topepo merged commit a9889f0 into main Oct 29, 2024
10 checks passed
@topepo topepo deleted the keep-ordered-class branch October 29, 2024 10:34
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants