Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependency on dev yardstick #694

Merged
merged 2 commits into from
Jul 21, 2023
Merged

remove dependency on dev yardstick #694

merged 2 commits into from
Jul 21, 2023

Conversation

simonpcouch
Copy link
Contributor

Following up on #684 in anticipation of a tune patch release after rsample. The functionality added in that PR won't kick in with previous yardstick versions, so this PR temporarily removes the unneeded dev dependency.

If we merge this, we should open an issue reminding us to revert these changes after the upcoming tune release. :)

@simonpcouch
Copy link
Contributor Author

Cloud revdepcheck ref for this PR is "6272d95f-7fdf-44c8-bbab-c6d27e3b7f40".

@simonpcouch
Copy link
Contributor Author

One new failure, with stacks:

Status: BROKEN

── Newly failing

✖ checking re-building of vignette outputs ... WARNING

── Before ─────────────────────────────────────────────────────────────────────────────────────
0 errors ✔ | 0 warnings ✔ | 0 notes ✔

── After ──────────────────────────────────────────────────────────────────────────────────────
❯ checking re-building of vignette outputs ... WARNING
  Error(s) in re-building vignettes:
    ...
  --- re-building ‘basics.Rmd’ using rmarkdown
  
  Quitting from lines 293-300 [unnamed-chunk-17] (basics.Rmd)
  Error: processing vignette 'basics.Rmd' failed with diagnostics:
  Can't subset columns that don't exist.
  ✖ Column `latency` doesn't exist.
  --- failed re-building ‘basics.Rmd’
  
  --- re-building ‘classification.Rmd’ using rmarkdown
  --- finished re-building ‘classification.Rmd’
  
  SUMMARY: processing the following file failed:
    ‘basics.Rmd’
  
  Error: Vignette re-building failed.
  Execution halted

0 errors ✔ | 1 warning ✖ | 0 notes ✔

🧐

@topepo
Copy link
Member

topepo commented Jul 21, 2023

I just tried and got

revdepcheck::cloud_status()
SUCCEEDED: [0/0/27/0 - 27] 00:18:50 | ETA: Done

I'll merge and we'll see what happens!

@topepo topepo merged commit c58bfb1 into main Jul 21, 2023
@topepo topepo deleted the followup-684 branch July 21, 2023 10:12
@github-actions
Copy link

github-actions bot commented Aug 5, 2023

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants