align machinery for ".by" and ".eval_time" grouping
#700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #702 |
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #699. The diff of #684 looks quite clean but it actually obscures a bad merge upstream with #619. In the first few lines of
estimate_tune_results(), #619 initialized agroup_colsobject, and #684 later overwrote it. This PR moves the logic for additionally summarizing by".by"into the helper used for".eval_time"and then uses the pattern from #619 otherwise.Note that this changes the column ordering for
.eval_timerelative to.metricand.estimatorincollect_metrics(). We don't test that here or in extratests, so I didn't work around it, but we can.